Fixed $.Model.restore(true) overwriting associated (nested) models with plain objects#82
Closed
marnusw wants to merge 1 commit intojupiterjs:masterfrom
Closed
Fixed $.Model.restore(true) overwriting associated (nested) models with plain objects#82marnusw wants to merge 1 commit intojupiterjs:masterfrom
marnusw wants to merge 1 commit intojupiterjs:masterfrom
Conversation
…updates the property using its own .attrs() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when backup/restore is used to restore a model with the restoreAssociations option the nested model is lost because it is overwritten by the plain object from the store. I propose checking whether the current property is a nested model and in that case setting its values with its own
attrs()method. This preserves the nested model and also causes it to trigger the appropriate update events etc.Two things though: